Skip to content

Test Python thread safety with pytest-run-parallel#42

Closed
cclauss wants to merge 1 commit intovalkey-io:mainfrom
cclauss:pytest-run-parallel
Closed

Test Python thread safety with pytest-run-parallel#42
cclauss wants to merge 1 commit intovalkey-io:mainfrom
cclauss:pytest-run-parallel

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Nov 4, 2025 •
edited
Loading

https://py-free-threading.github.io
https://pypi.org/project/pytest-run-parallel

% uvx --with="valkey[libvalkey]" python3.14t -c "import valkey"

Installed 2 packages in 5ms
<frozen importlib._bootstrap>:491: RuntimeWarning: The global interpreter lock (GIL) has been enabled to
    load module 'libvalkey.libvalkey', which has not declared that it can run safely without the GIL.
    To override this behavior and keep the GIL disabled (at your own risk), run with PYTHON_GIL=0 or -Xgil=0.

Copilot AI review requested due to automatic review settings November 4, 2025 15:41
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI infrastructure and testing strategy by bumping GitHub Actions versions, adding parallel test execution capabilities, and dropping support for Python 3.8 and PyPy 3.8.

  • Upgraded GitHub Actions (actions/checkout v4→v5, actions/setup-python v5→v6)
  • Added pytest-run-parallel for running tests multiple times in parallel
  • Removed Python 3.8 and PyPy 3.8 from the test matrix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dev_requirements.txt Added pytest-run-parallel dependency for parallel test execution
.github/workflows/integration.yaml Updated GitHub Actions versions, removed Python 3.8 support, and enabled parallel test execution with 8 iterations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 4, 2025 15:55
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 4, 2025 16:07
@cclauss cclauss force-pushed the pytest-run-parallel branch from 5afde51 to 21215b0 Compare November 4, 2025 16:07
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cclauss cclauss force-pushed the pytest-run-parallel branch from 21215b0 to ce5ec55 Compare November 4, 2025 16:17
Copilot AI review requested due to automatic review settings November 4, 2025 16:18
@cclauss cclauss force-pushed the pytest-run-parallel branch 2 times, most recently from 507dc1e to 7b3c5cc Compare November 4, 2025 16:20
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This was referenced Nov 4, 2025
Closed
Draft
Closed
mkmkme
mkmkme reviewed Nov 4, 2025
View reviewed changes
mkmkme
mkmkme reviewed Nov 4, 2025
View reviewed changes
@cclauss cclauss mentioned this pull request Nov 6, 2025
Merged
@cclauss
Test Python thread safety with pytest-run-parallel
43f1d9a 
Signed-off-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss force-pushed the pytest-run-parallel branch from 7b3c5cc to 43f1d9a Compare November 6, 2025 12:42
@cclauss cclauss requested a review from mkmkme November 6, 2025 12:44
@cclauss cclauss mentioned this pull request Nov 6, 2025
Merged
@mkmkme
Copy link
Copy Markdown
Collaborator

mkmkme commented Nov 8, 2025

Closing due to lack of support for free threaded Python in this module at this moment. See #52 (comment)

@mkmkme mkmkme closed this Nov 8, 2025
@cclauss cclauss deleted the pytest-run-parallel branch November 8, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mkmkme mkmkme Awaiting requested review from mkmkme

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @mkmkme